Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zenroom): initialize zenroom before script check, in this way the error on empty script follows the logfmt specification #892

Merged
merged 2 commits into from
Jun 30, 2024
Merged

fix(zenroom): initialize zenroom before script check, in this way the error on empty script follows the logfmt specification #892

merged 2 commits into from
Jun 30, 2024

Conversation

matteo-cristino
Copy link
Collaborator

  • fix(zenroom): initialize zenroom before script check, in this way the error on empty script follows the logfmt specification
  • test(js): update error returned by empty script

@matteo-cristino matteo-cristino linked an issue Jun 24, 2024 that may be closed by this pull request
On empty string contract logs is not a json in js #891
Closed
@matteo-cristino
Copy link
Collaborator Author

There are still some _err() calls that does not follow the logfmt specified in the conf, but these can not be directly substituted with zerror() since are zenroom or lua initialization error. Another solution should be found for these cases to report errors with the right format.

@jaromil jaromil mentioned this pull request Jun 30, 2024
Open
@jaromil jaromil merged commit 4917528 into master Jun 30, 2024
26 checks passed
@jaromil jaromil deleted the fix/init_error branch June 30, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puria puria puria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On empty string contract logs is not a json in js
3 participants
@matteo-cristino @puria @jaromil